Better appearance integration, allowing easy themeability #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the menu entries use the same CSS classes used in the Gnome calendar if 'Use system theme' is set in prefernces. The CSS classes defined in `stylesheet.css` are used otherwise.
Now the only hardcoded CSS styling is the italic style for multiday tasks. Hardcoding colors could bring to visibility problems due to shell themeing.
Conflicts: [email protected]/gtgcalendarmenu.js [email protected]/gtgtodomenu.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just merged your last changes (basically identical to mine, of course) so you should not get conflicts anymore if you will accept this pull request.
What I tried to do in this code is basically make the appearance of new GTG columns just like the
Calendar.EventsList. To achieve the goal, now the items in GTG columns rely on CSS classes used inCalendar.EventsListrather than the ones set instylesheet.css. The latter are still used if the optionUse system themeis turned off, so that the user can override the system theme. That way, the appearance will be consistent even if the user changes the shell theme (using the User Themes extension).I had to use some vodoo (
xyz.actor.remove_style_class_name("foo")because the GTG menu is built in a completely different way than theCalendar.EventsList(usingPopupMenuItemfor headers too).So, in short:
Use system themeisOn, theCalendar.EventsListCSS classes are used (plus some tweak instylesheet.css.Use system themeisOff, the*-customCSS classes instylesheet.cssare used, completely overriding the system theme.As a plus:
gtgtodomenus.jsI hope the changes will be considered useful. Of course, we can discuss anything, if you want. Thanks for your work, anyway. And happy holidays!